lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disco: amplify comment that disco ping's NodeKey shouldn't be trusted by itself. 

Signed-off-by: David Anderson <danderson@tailscale.com>
pull/3027/head
David Anderson 2021-10-18 10:50:13 -07:00
parent cb030a0bb4
commit 1c56643136
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
disco/disco.go
View File

@ -110,11 +110,12 @@ type Ping struct {
// TxID is a random client-generated per-ping transaction ID. // TxID is a random client-generated per-ping transaction ID.
TxID [12]byte TxID [12]byte
// NodeKey is the ping sender's wireguard public key. Old // NodeKey is allegedly the ping sender's wireguard public key.
// clients (~1.16.0 and earlier) don't send this field. It // Old clients (~1.16.0 and earlier) don't send this field.
// shouldn't be trusted by itself. But if present and the
// netmap's peer for this NodeKey's DiscoKey matches the // It shouldn't be trusted by itself, but can be combined with
// sender of this disco key, they it can be. // netmap data to reduce the discokey:nodekey relation from 1:N to
// 1:1.
NodeKey tailcfg.NodeKey NodeKey tailcfg.NodeKey
} }