lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/dns/resolver: add comments clarifying nil error returns 

Signed-off-by: Maisem Ali <maisem@tailscale.com>
pull/5323/head
Maisem Ali 2022-08-09 13:29:34 -07:00 committed by Maisem Ali
parent 4497bb0b81
commit 3bb57504af
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/dns/resolver/forwarder.go
View File

@ -676,6 +676,8 @@ func (f *forwarder) forwardWithDestChan(ctx context.Context, query packet, respo
res, err := nxDomainResponse(query)
if err != nil {
f.logf("error parsing bonjour query: %v", err)
// Returning an error will cause an internal retry, there is
// nothing we can do if parsing failed. Just drop the packet.
return nil
}
select {
@ -700,6 +702,8 @@ func (f *forwarder) forwardWithDestChan(ctx context.Context, query packet, respo
res, err := servfailResponse(query)
if err != nil {
f.logf("building servfail response: %v", err)
// Returning an error will cause an internal retry, there is
// nothing we can do if parsing failed. Just drop the packet.
return nil
}
select {