lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wgengine/filter: eliminate unnecessary memory loads. 

Doesn't materially affect benchmarks, but shrinks match6 by 30 instructions
and halves memory loads.

Part of #19.

Signed-off-by: David Anderson <danderson@tailscale.com>
pull/918/head
David Anderson 2020-11-12 20:06:26 -08:00
parent 47380ebcfb
commit 3fdae12f0c
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
wgengine/filter/match6.go
View File

@ -118,15 +118,16 @@ func newMatches6(ms []Match) (ret matches6) {
}
func (ms matches6) match(q *packet.Parsed) bool {
for _, m := range ms {
if !ip6InList(q.SrcIP6, m.srcs) {
for i := range ms {
if !ip6InList(q.SrcIP6, ms[i].srcs) {
continue
}
for _, dst := range m.dsts {
if !dst.net.Contains(q.DstIP6) {
dsts := ms[i].dsts
for i := range dsts {
if !dsts[i].net.Contains(q.DstIP6) {
continue
}
if !dst.ports.contains(q.DstPort) {
if !dsts[i].ports.contains(q.DstPort) {
continue
}
return true