lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wgengine/router: use net.IP.Equal instead of bytes.Equal to compare IPs 

Signed-off-by: Josh Bleecher Snyder <josharian@gmail.com>
pull/1846/head
Josh Bleecher Snyder 2021-05-03 13:05:00 -07:00
parent 737151ea4a
commit 47ebd1e9a2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wgengine/router/ifconfig_windows.go
View File

@ -377,7 +377,7 @@ func configureInterface(cfg *Config, tun *tun.NativeTun) (retErr error) {
NextHop: gateway, NextHop: gateway,
Metric: 0, Metric: 0,
} }
if bytes.Compare(r.Destination.IP, gateway) == 0 { if net.IP.Equal(r.Destination.IP, gateway) {
// no need to add a route for the interface's // no need to add a route for the interface's
// own IP. The kernel does that for us. // own IP. The kernel does that for us.
// If we try to replace it, we'll fail to // If we try to replace it, we'll fail to
@ -411,7 +411,7 @@ func configureInterface(cfg *Config, tun *tun.NativeTun) (retErr error) {
// There's only one way to get to a given IP+Mask, so delete // There's only one way to get to a given IP+Mask, so delete
// all matches after the first. // all matches after the first.
if i > 0 && if i > 0 &&
bytes.Equal(routes[i].Destination.IP, routes[i-1].Destination.IP) && net.IP.Equal(routes[i].Destination.IP, routes[i-1].Destination.IP) &&
bytes.Equal(routes[i].Destination.Mask, routes[i-1].Destination.Mask) { bytes.Equal(routes[i].Destination.Mask, routes[i-1].Destination.Mask) {
continue continue
} }