From 6e4231c03ce8d111af2c9d3bb1ff5b2f7df0846c Mon Sep 17 00:00:00 2001 From: Alex Brainman Date: Wed, 13 Jan 2021 18:49:33 +1100 Subject: [PATCH] wgengine/router/dns: remove unused code MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Commit 68ddf1 removed code that reads `SOFTWARE\Tailscale IPN\SearchList` registry value. But the commit left code that writes that value. So now this package writes and never reads the value. Remove the code to stop pointless work. Updates #853 Signed-off-by: Alex Brainman --- wgengine/router/dns/manager_windows.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/wgengine/router/dns/manager_windows.go b/wgengine/router/dns/manager_windows.go index b71b2255c..5940404e7 100644 --- a/wgengine/router/dns/manager_windows.go +++ b/wgengine/router/dns/manager_windows.go @@ -18,7 +18,6 @@ import ( const ( ipv4RegBase = `SYSTEM\CurrentControlSet\Services\Tcpip\Parameters` ipv6RegBase = `SYSTEM\CurrentControlSet\Services\Tcpip6\Parameters` - tsRegBase = `SOFTWARE\Tailscale IPN` ) type windowsManager struct { @@ -91,11 +90,6 @@ func (m windowsManager) Up(config Config) error { return err } - newSearchList := strings.Join(config.Domains, ",") - if err := setRegistryString(tsRegBase, "SearchList", newSearchList); err != nil { - return err - } - // Force DNS re-registration in Active Directory. What we actually // care about is that this command invokes the undocumented hidden // function that forces Windows to notice that adapter settings