From be56aa49626ae2e5459ad386daaac79f23eaf1e3 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Thu, 29 Apr 2021 12:44:23 -0700 Subject: [PATCH] workflows: execute benchmarks #1817 removed the only place in our CI where we executed our benchmark code. Fix that by executing it everywhere. The benchmarks are generally cheap and fast, so this should add minimal overhead. Signed-off-by: Josh Bleecher Snyder --- .github/workflows/linux-race.yml | 4 ++-- .github/workflows/linux.yml | 2 +- .github/workflows/linux32.yml | 2 +- .github/workflows/windows-race.yml | 5 ++++- .github/workflows/windows.yml | 5 ++++- 5 files changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/linux-race.yml b/.github/workflows/linux-race.yml index 4f373cdc4..03b5dccd6 100644 --- a/.github/workflows/linux-race.yml +++ b/.github/workflows/linux-race.yml @@ -28,8 +28,8 @@ jobs: - name: Basic build run: go build ./cmd/... - - name: Run tests with -race flag on linux - run: go test -race ./... + - name: Run tests and benchmarks with -race flag on linux + run: go test -race -bench=. -benchtime=1x ./... - uses: k0kubun/action-slack@v2.0.0 with: diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index e7d1ff9a6..b4f82b6ef 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -29,7 +29,7 @@ jobs: run: go build ./cmd/... - name: Run tests on linux - run: go test ./... + run: go test -bench=. -benchtime=1x ./... - uses: k0kubun/action-slack@v2.0.0 with: diff --git a/.github/workflows/linux32.yml b/.github/workflows/linux32.yml index cbd812569..79a229d16 100644 --- a/.github/workflows/linux32.yml +++ b/.github/workflows/linux32.yml @@ -29,7 +29,7 @@ jobs: run: GOARCH=386 go build ./cmd/... - name: Run tests on linux - run: GOARCH=386 go test ./... + run: GOARCH=386 go test -bench=. -benchtime=1x ./... - uses: k0kubun/action-slack@v2.0.0 with: diff --git a/.github/workflows/windows-race.yml b/.github/workflows/windows-race.yml index f2111f028..a3c99822f 100644 --- a/.github/workflows/windows-race.yml +++ b/.github/workflows/windows-race.yml @@ -33,7 +33,10 @@ jobs: ${{ runner.os }}-go- - name: Test with -race flag - run: go test -race ./... + # Don't use -bench=. -benchtime=1x. + # Somewhere in the layers (powershell?) + # the equals signs cause great confusion. + run: go test -race -bench . -benchtime 1x ./... - uses: k0kubun/action-slack@v2.0.0 with: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 52ed8cbe2..2783e3aee 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -33,7 +33,10 @@ jobs: ${{ runner.os }}-go- - name: Test - run: go test ./... + # Don't use -bench=. -benchtime=1x. + # Somewhere in the layers (powershell?) + # the equals signs cause great confusion. + run: go test -bench . -benchtime 1x ./... - uses: k0kubun/action-slack@v2.0.0 with: