lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wgengine: access flow pending problem with lock held 

Missed review feedback from just-submitted d37058af72.

(cherry picked from commit 70eb05fd47)
bradfitz/proposed-1.4.5
Brad Fitzpatrick 2021-02-04 11:18:32 -08:00
parent acc50d6b67
commit c027962893
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
wgengine/pendopen.go
View File

@ -132,10 +132,11 @@ func (e *userspaceEngine) onOpenTimeout(flow flowtrack.Tuple) {
return return
} }
delete(e.pendOpen, flow) delete(e.pendOpen, flow)
problem := of.problem
e.mu.Unlock() e.mu.Unlock()
if !of.problem.IsZero() { if !problem.IsZero() {
e.logf("open-conn-track: timeout opening %v; peer reported problem: %v", flow, of.problem) e.logf("open-conn-track: timeout opening %v; peer reported problem: %v", flow, problem)
} }
// Diagnose why it might've timed out. // Diagnose why it might've timed out.