lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

syncs: stop running TestWatchMultipleValues on CI 

It's flaky, and not just on Windows.

Signed-off-by: Josh Bleecher Snyder <josharian@gmail.com>
bradfitz/log_rate_test
Josh Bleecher Snyder 2021-05-04 09:24:52 -07:00
parent f5bccc0746
commit d3ba860ffd
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
syncs/watchdog_test.go
View File

@ -6,7 +6,6 @@ package syncs
import ( import (
"context" "context"
"runtime"
"sync" "sync"
"testing" "testing"
"time" "time"
@ -49,11 +48,11 @@ func TestWatchContended(t *testing.T) {
} }
func TestWatchMultipleValues(t *testing.T) { func TestWatchMultipleValues(t *testing.T) {
if cibuild.On() && runtime.GOOS == "windows" { if cibuild.On() {
// On the CI machine, it sometimes takes 500ms to start a new goroutine. // On the CI machine, it sometimes takes 500ms to start a new goroutine.
// When this happens, we don't get enough events quickly enough. // When this happens, we don't get enough events quickly enough.
// Nothing's wrong, and it's not worth working around. Just skip the test. // Nothing's wrong, and it's not worth working around. Just skip the test.
t.Skip("flaky on Windows CI") t.Skip("flaky on CI")
} }
mu := new(sync.Mutex) mu := new(sync.Mutex)
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())