From e26376194dbc710ae3daf6f5bea085e0a8eb3587 Mon Sep 17 00:00:00 2001
From: valscale <valerie@tailscale.com>
Date: Tue, 27 Jun 2023 09:33:29 -0700
Subject: [PATCH] ipn/ipnlocal: validate ping type (#8458)

Correct a minor cut-n-paste error that resulted in an invalid or
missing ping type being accepted as a disco ping.

Fixes #8457

Signed-off-by: Val <valerie@tailscale.com>
---
 ipn/localapi/localapi.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipn/localapi/localapi.go b/ipn/localapi/localapi.go
index d99dcad88..4c0dbd480 100644
--- a/ipn/localapi/localapi.go
+++ b/ipn/localapi/localapi.go
@@ -1331,7 +1331,7 @@ func (h *Handler) servePing(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	pingTypeStr := r.FormValue("type")
-	if ipStr == "" {
+	if pingTypeStr == "" {
 		http.Error(w, "missing 'type' parameter", 400)
 		return
 	}