lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wgengine: remove IpcGetOperation filter 

This was in place because retrieved allowed_ips was very expensive.
Upstream changed the data structure to make them cheaper to compute.

This commit is an experiment to find out whether they're now cheap enough.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
pull/1301/head
Josh Bleecher Snyder 2021-02-08 13:34:27 -08:00 committed by Josh Bleecher Snyder
parent 6b365b0239
commit e7caad61fb
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
wgengine/userspace.go
View File

@ -1075,12 +1075,7 @@ func (e *userspaceEngine) getStatus() (*Status, error) {
defer pw.Close() defer pw.Close()
// TODO(apenwarr): get rid of silly uapi stuff for in-process comms // TODO(apenwarr): get rid of silly uapi stuff for in-process comms
// FIXME: get notified of status changes instead of polling. // FIXME: get notified of status changes instead of polling.
filter := device.IPCGetFilter{ err := e.wgdev.IpcGetOperation(pw)
// The allowed_ips are somewhat expensive to compute and they're
// unused below; request that they not be sent instead.
FilterAllowedIPs: true,
}
err := e.wgdev.IpcGetOperationFiltered(pw, filter)
if err != nil { if err != nil {
err = fmt.Errorf("IpcGetOperation: %w", err) err = fmt.Errorf("IpcGetOperation: %w", err)
} }