tailscale

History

Brad Fitzpatrick 7f68e097dd net/netcheck: fix HTTPS fallback bug from earlier today My earlier `3fa58303d0` tried to implement the net/http.Tranhsport.DialTLSContext hook, but I didn't return a *tls.Conn, so we ended up sending a plaintext HTTP request to an HTTPS port. The response ended up being Go telling as such, not the /derp/latency-check handler's response (which is currently still a 404). But we didn't even get the 404. This happened to work well enough because Go's built-in error response was still a valid HTTP response that we can measure for timing purposes, but it's not a great answer. Notably, it means we wouldn't be able to get a future handler to run server-side and count those latency requests.	2020-05-29 22:33:08 -07:00
..
netcheck.go	net/netcheck: fix HTTPS fallback bug from earlier today	2020-05-29 22:33:08 -07:00
netcheck_test.go	net/netns: set the bypass socket mark on linux.	2020-05-29 15:16:58 -07:00

Brad Fitzpatrick 7f68e097dd net/netcheck: fix HTTPS fallback bug from earlier today

My earlier 3fa58303d0 tried to implement
the net/http.Tranhsport.DialTLSContext hook, but I didn't return a
*tls.Conn, so we ended up sending a plaintext HTTP request to an HTTPS
port. The response ended up being Go telling as such, not the
/derp/latency-check handler's response (which is currently still a
404). But we didn't even get the 404.

This happened to work well enough because Go's built-in error response
was still a valid HTTP response that we can measure for timing
purposes, but it's not a great answer. Notably, it means we wouldn't
be able to get a future handler to run server-side and count those
latency requests.

2020-05-29 22:33:08 -07:00

netcheck.go net/netcheck: fix HTTPS fallback bug from earlier today 2020-05-29 22:33:08 -07:00

netcheck_test.go net/netns: set the bypass socket mark on linux. 2020-05-29 15:16:58 -07:00