lzc256
/
tailscale
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wgengine/router/dns: remove unused code 

Commit 68ddf1 removed code that reads
`SOFTWARE\Tailscale IPN\SearchList` registry value. But the commit
left code that writes that value.

So now this package writes and never reads the value.

Remove the code to stop pointless work.

Updates #853

Signed-off-by: Alex Brainman <alex.brainman@gmail.com>
pull/1136/head
Alex Brainman 2021-01-13 18:49:33 +11:00 committed by Brad Fitzpatrick
parent 654b5f1570
commit 6e4231c03c
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
wgengine/router/dns/manager_windows.go
View File

@ -18,7 +18,6 @@ import (
const ( const (
ipv4RegBase = `SYSTEM\CurrentControlSet\Services\Tcpip\Parameters` ipv4RegBase = `SYSTEM\CurrentControlSet\Services\Tcpip\Parameters`
ipv6RegBase = `SYSTEM\CurrentControlSet\Services\Tcpip6\Parameters` ipv6RegBase = `SYSTEM\CurrentControlSet\Services\Tcpip6\Parameters`
tsRegBase = `SOFTWARE\Tailscale IPN`
) )
type windowsManager struct { type windowsManager struct {
@ -91,11 +90,6 @@ func (m windowsManager) Up(config Config) error {
return err return err
} }
newSearchList := strings.Join(config.Domains, ",")
if err := setRegistryString(tsRegBase, "SearchList", newSearchList); err != nil {
return err
}
// Force DNS re-registration in Active Directory. What we actually // Force DNS re-registration in Active Directory. What we actually
// care about is that this command invokes the undocumented hidden // care about is that this command invokes the undocumented hidden
// function that forces Windows to notice that adapter settings // function that forces Windows to notice that adapter settings